Update lifecycle badges by m7pr · Pull Request #268 · insightsengineering/teal.code

m7pr · 2025-08-11T09:47:05Z

Both experimental and deprecated badges were added at the latest version 0.6.1 so no need for the updates #239
Only added experimental for the new function: get_outputs.

github-actions · 2025-08-11T09:52:38Z

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      13       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  60       1  98.33%   40
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_outputs.R                 6       0  100.00%
R/qenv-get_var.R                    13       1  92.31%   13
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        1       1  0.00%    13
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                       29      29  0.00%    19-50
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      254       3  98.82%   160, 258, 331
R/utils.R                           42       0  100.00%
TOTAL                              562      41  92.70%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/qenv-get_var.R      -13      +1  -7.69%
R/qenv-join.R          -6      -6  +100.00%
TOTAL                 -19      -5  +0.62%

Results for commit: aa1a5ba

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2025-08-11T09:52:59Z

Unit Tests Summary

1 files 14 suites 5s ⏱️
171 tests 168 ✅ 3 💤 0 ❌
254 runs 251 ✅ 3 💤 0 ❌

Results for commit aa1a5ba.

♻️ This comment has been updated with latest results.

gogonzo · 2025-08-11T13:36:47Z

Both experimental and deprecated badges were added at the latest version 0.6.1 so no need for the updates #239 Only added experimental for the new function: get_outputs.

All deprecations have been added at 0.6.0 which means that we should deprecate_stop now

m7pr · 2025-08-11T14:22:15Z

@gogonzo for the deprecate_stop do you think we should deleted examples, tests and body of the function (besides the lifecycle check)?

gogonzo · 2025-08-12T05:26:48Z

@gogonzo for the deprecate_stop do you think we should deleted examples, tests and body of the function (besides the lifecycle check)?

Yes

m7pr · 2025-08-12T07:41:31Z

Her deprecated methods in fcf46ed

…ng/teal.code into lifecycle@main

github-actions · 2025-08-12T08:25:57Z

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
qenv_get_var	👶		$+0.01$	and_only_returns_objects_from_qenv_not.GlobalEnv
qenv_get_var	👶		$+0.01$	and_only_returns_objects_from_qenv_not_parent_environment_s
qenv_get_var	👶		$+0.03$	_and_return_NULL_if_object_not_in_qenv_environment
qenv_get_var	👶		$+0.04$	_and_return_error_if_object_is_qenv.error
qenv_get_var	👶		$+0.03$	_and_return_object_from_qenv_environment
qenv_get_var	💀	$0.01$	$-0.01$	get_var_and_only_returns_objects_from_qenv_not_.GlobalEnv
qenv_get_var	💀	$0.01$	$-0.01$	get_var_and_only_returns_objects_from_qenv_not_parent_environment_s_
qenv_get_var	💀	$0.04$	$-0.04$	get_var_and_return_NULL_if_object_not_in_qenv_environment
qenv_get_var	💀	$0.05$	$-0.05$	get_var_and_return_error_if_object_is_qenv.error
qenv_get_var	💀	$0.11$	$-0.11$	get_var_and_return_object_from_qenv_environment

Results for commit 6b4af4a

♻️ This comment has been updated with latest results.

gogonzo

👍

gogonzo · 2025-08-12T09:26:59Z

-    class = c("validation", "try-error", "simpleError")
-  ))
-})
+get_var <- function(...) lifecycle::deprecate_stop("0.6.0", "get_var()", "base::get()")


Does It suppose to be when = "0.6.2"?

vedhav · 2025-08-13T10:38:01Z

@insightsengineering/nest-core-dev TODO: Please update these places where teal.code::get_var are used/mentioned:

In teal we use it here and it is causing the app to fail.
In teal.connectors.ssh a test uses this.
teal.data docs mentioned it here.

llrs-roche · 2025-08-25T14:15:07Z

@insightsengineering/nest-core-dev TODO: Please update these places where teal.code::get_var are used/mentioned:

In teal we use it here and it is causing the app to fail.

Couldn't find on main fixed on insightsengineering/teal#1576

The other two aren't fixed. Maybe I'll create an issue to don't forget about those (specially because it has teal.connectors.ssh repo that I was not aware of).

In teal.connectors.ssh a test uses this.

teal.data docs mentioned it here.
Still there.

add experimental badge to get_outputs

b98c0ce

m7pr requested a review from gogonzo August 11, 2025 09:47

m7pr added the core label Aug 11, 2025

[skip style] [skip vbump] Restyle files

f039848

gogonzo reviewed Aug 11, 2025

View reviewed changes

Comment thread R/qenv-get_outputs.R

gogonzo self-assigned this Aug 11, 2025

hard deprecate join and get_var

fcf46ed

m7pr requested a review from gogonzo August 12, 2025 07:41

github-actions Bot and others added 3 commits August 12, 2025 07:43

[skip style] [skip vbump] Restyle files

a3da6e9

fix r cmd check

2df511d

Merge branch 'lifecycle@main' of https://github.com/insightsengineeri…

3ceb4f7

…ng/teal.code into lifecycle@main

gogonzo reviewed Aug 12, 2025

View reviewed changes

Comment thread R/qenv-get_var.R Outdated

gogonzo reviewed Aug 12, 2025

View reviewed changes

Comment thread R/qenv-join.R Outdated

change join and get_var to s3

2c25b4d

m7pr requested a review from gogonzo August 12, 2025 08:58

m7pr enabled auto-merge (squash) August 12, 2025 08:58

[skip style] [skip vbump] Restyle files

aa1a5ba

gogonzo approved these changes Aug 12, 2025

View reviewed changes

m7pr merged commit 4a1f518 into main Aug 12, 2025
28 of 29 checks passed

m7pr deleted the lifecycle@main branch August 12, 2025 09:09

github-actions Bot locked and limited conversation to collaborators Aug 12, 2025

gogonzo reviewed Aug 12, 2025

View reviewed changes

Uh oh!

Uh oh!

Conversation

m7pr commented Aug 11, 2025

Uh oh!

github-actions Bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Diff against main

Uh oh!

github-actions Bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests Summary

Uh oh!

gogonzo commented Aug 11, 2025

Uh oh!

Uh oh!

m7pr commented Aug 11, 2025

Uh oh!

gogonzo commented Aug 12, 2025

Uh oh!

m7pr commented Aug 12, 2025

Uh oh!

github-actions Bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Performance Difference

Uh oh!

Uh oh!

Uh oh!

gogonzo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gogonzo Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vedhav commented Aug 13, 2025

Uh oh!

llrs-roche commented Aug 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Aug 11, 2025 •

edited

Loading

github-actions Bot commented Aug 11, 2025 •

edited

Loading

github-actions Bot commented Aug 12, 2025 •

edited

Loading

gogonzo Aug 12, 2025 •

edited

Loading